Add int dtype to labels_pred in mutual_info_score()#15462
Merged
TomDLT merged 1 commit intoscikit-learn:masterfrom Nov 2, 2019
Merged
Add int dtype to labels_pred in mutual_info_score()#15462TomDLT merged 1 commit intoscikit-learn:masterfrom
TomDLT merged 1 commit intoscikit-learn:masterfrom
Conversation
Member
|
Thanks @ganevgv ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
What does this implement/fix? Explain your changes.
This PR specifies the dtypes of arguments in
sklearn.metrics.mutual_info_score,sklearn.metrics.adjusted_mutual_info_scoreandsklearn.metrics.normalized_mutual_info_score. In the current documentation, the dtype oflabels_trueis specified to beintbut the dtype oflabels_predis not specified. Since our goal is to compare the two clusterings and the metrics are symmetric the two arguments should have the same dtypes.Any other comments?