MAINT Fixes test_fit_csr_matrix on py35 conda#15158
Merged
rth merged 2 commits intoscikit-learn:masterfrom Oct 20, 2019
Merged
Conversation
Member
Author
|
@NicolasHug Most likely an easy review? |
rth
approved these changes
Oct 16, 2019
Member
rth
left a comment
There was a problem hiding this comment.
This certainly won't hurt, but that still means that the conditions we test for is too strict and won't pass for any random state. Though given that it repeatably fails only on py35 job (and passes elsewhere), I wonder if it's linked to numpy versions.
NicolasHug
approved these changes
Oct 17, 2019
Member
NicolasHug
left a comment
There was a problem hiding this comment.
LGTM, but I agree with @rth's concern.
How stable is the test w.r.t the random seed?
Member
|
I this there is no risk with merging it, as it's an improvement in any case. As to whether it will fix the corresponding issues, we'll see. If CI fails again we can always reopen (but I hope we will also drop py36 soon). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
Fixes #14168
What does this implement/fix? Explain your changes.
Makes everything deterministic in
test_fit_csr_matrix.