strict mode added for check_estimator#14929
Closed
hirenmayani wants to merge 1 commit intoscikit-learn:masterfrom
Closed
strict mode added for check_estimator#14929hirenmayani wants to merge 1 commit intoscikit-learn:masterfrom
hirenmayani wants to merge 1 commit intoscikit-learn:masterfrom
Conversation
Member
|
Hey. Are you still working on this or would you prefer someone else take it over? |
This was referenced Apr 9, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
Example: Fixes #13969 Add non-strict mode to check_estimator
What does this implement/fix? Explain your changes.
This implementation provides 'strict mode' for check_estimator function. If strict mode is false, then check_estimator function will assert only based on error type, not on error message.
By default, value of this variable is True. So, it won't change existing behavior of any function.