Fix float->int casting with NaN, inf in check_array#14872
Merged
glemaitre merged 6 commits intoscikit-learn:masterfrom Sep 20, 2019
Merged
Fix float->int casting with NaN, inf in check_array#14872glemaitre merged 6 commits intoscikit-learn:masterfrom
glemaitre merged 6 commits intoscikit-learn:masterfrom
Conversation
jnothman
reviewed
Sep 3, 2019
qinhanmin2014
approved these changes
Sep 5, 2019
Member
qinhanmin2014
left a comment
There was a problem hiding this comment.
I can't come up with a better solution, so LGTM.
Member
|
Please add an entry to the change log at |
4 tasks
glemaitre
reviewed
Sep 17, 2019
Member
|
I'll merge when it is green |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #14871
Numpy rules when converting float to int convert NaN, inf to
np.iinfo(dtype).min/maxinstead of raising an error. It would be good to address this in numpy somehow numpy/numpy#14412 but meanwhile we can manually apply_assert_all_finitein this case (even withforce_all_finite=False)cc @qinhanmin2014
TODO:
test_encoders.pytests