MAINT Fix assert raises in sklearn/semi_supervised/tests/#14841
Merged
thomasjpfan merged 2 commits intoscikit-learn:masterfrom Sep 8, 2019
sameshl:tests_semi_supervised
Merged
MAINT Fix assert raises in sklearn/semi_supervised/tests/#14841thomasjpfan merged 2 commits intoscikit-learn:masterfrom sameshl:tests_semi_supervised
thomasjpfan merged 2 commits intoscikit-learn:masterfrom
sameshl:tests_semi_supervised
Conversation
Contributor
Author
|
@rth Could you have a look at this? |
thomasjpfan
reviewed
Sep 6, 2019
| label_propagation.LabelSpreading(**kwargs).fit(X, y), | ||
| alpha=alpha) | ||
| with pytest.raises(ValueError): | ||
| (lambda **kwargs: |
Member
There was a problem hiding this comment.
That is a weird use case for lambda. This should also work:
label_propagation.LabelSpreading(alpha=alpha).fit(X, y)
Contributor
Author
There was a problem hiding this comment.
@thomasjpfan I have corrected it. Let me know if anything else needs to be done.
sklearn/semi_supervised/tests/
Member
|
Thank you @sameshl ! |
Contributor
Author
|
Thanks @thomasjpfan! |
43 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
replaced
assert_raisesandassert_raises_regexwithpytest.raisescontext manager.related to #14216