Removed redundant parameters of 2 classes#14796
Removed redundant parameters of 2 classes#14796thomasjpfan merged 3 commits intoscikit-learn:masterfrom
Conversation
rth
left a comment
There was a problem hiding this comment.
PEP8 formatting issues, otherwise LGTM. Thanks!
| # Generate data | ||
| X, y = make_blobs(n_samples=1000, n_features=2, random_state=42, | ||
| X, y = make_blobs(n_samples=1000, random_state=42, | ||
| cluster_std=5.0) |
| X, y = datasets.make_classification(n_samples=100000, n_features=20, | ||
| n_informative=2, n_redundant=10, | ||
| X, y = datasets.make_classification(n_samples=100000, | ||
| n_redundant=10, |
There was a problem hiding this comment.
This is not PEP8 compliant (and also all of it could fit on a single line).
|
Thanks for the PR @RuchitaGarde , can you please address the comments? Thanks! |
NicolasHug
left a comment
There was a problem hiding this comment.
I've addressed the indentation comments, LGTM
|
@kellycarmody |
|
I will look into this. |
|
@RuchitaGarde I've addressed the comments already so no worries. Maybe other reviewers will require more changes, in which case we'll ping you again |
|
@RuchitaGarde @ttang131 If you haven't yet, please complete the sprint feedback survey. cc: @kellycarmody |
Reference Issues/PRs
Fixes #14351
What does this implement/fix? Explain your changes.
Removed redundant parameters from 2 classes:
make_blobs() - 2 instances
make_classification() - 1 instance
Any other comments?
Working with @ttang131