Skip to content

use return_X_y=True for load_iris dataset#14777

Merged
amueller merged 4 commits intoscikit-learn:masterfrom
kanikas3:use-return-iris
Aug 24, 2019
Merged

use return_X_y=True for load_iris dataset#14777
amueller merged 4 commits intoscikit-learn:masterfrom
kanikas3:use-return-iris

Conversation

@kanikas3
Copy link
Copy Markdown
Contributor

@kanikas3 kanikas3 commented Aug 24, 2019

Reference Issues/PRs

Partially fixes #14347

What does this implement/fix? Explain your changes.

for load_iris dataset uses return_X_y=True wherever applicable

Any other comments?

Copy link
Copy Markdown
Member

@amueller amueller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@NicolasHug
Copy link
Copy Markdown
Member

Almost good @kanikas3 , you'll need to update cross_validation.rst which is still using iris in some places (https://dev.azure.com/scikit-learn/scikit-learn/_build/results?buildId=6987)

@amueller amueller merged commit 40c7978 into scikit-learn:master Aug 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Use return_X_y=True when applicable in examples

3 participants