MAINT:Fix assert raises in sklearn/feature_selection/tests/#14697
Merged
qinhanmin2014 merged 10 commits intoscikit-learn:masterfrom Aug 21, 2019
sameshl:mnt_tests_feature_selection
Merged
MAINT:Fix assert raises in sklearn/feature_selection/tests/#14697qinhanmin2014 merged 10 commits intoscikit-learn:masterfrom sameshl:mnt_tests_feature_selection
sklearn/feature_selection/tests/#14697qinhanmin2014 merged 10 commits intoscikit-learn:masterfrom
sameshl:mnt_tests_feature_selection
Conversation
related to #14216
qinhanmin2014
approved these changes
Aug 21, 2019
|
|
||
| for X in [data, csr_matrix(data), csc_matrix(data), bsr_matrix(data)]: | ||
| sel = VarianceThreshold().fit(X) | ||
| assert_array_equal([0, 1, 3, 4], sel.get_support(indices=True)) |
Member
There was a problem hiding this comment.
I don't think it's good to use pytest.mark.parametrize here, because we'll run same test for multiple times.
…t_variance_threshold.py
|
|
||
| assert_raises(ValueError, VarianceThreshold().fit, [[0, 1, 2, 3]]) | ||
| assert_raises(ValueError, VarianceThreshold().fit, [[0, 1], [0, 1]]) | ||
|
|
Member
There was a problem hiding this comment.
do not remove this line, we need two lines between functions
qinhanmin2014
approved these changes
Aug 21, 2019
43 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
replaced
assert_raisesandassert_raises_regexwithpytest.raisescontext manager.related to #14216