Skip to content

MAINT Remove the use of assert_raises* in decomposition#14679

Merged
thomasjpfan merged 7 commits intoscikit-learn:masterfrom
sameshl:mnt_tests_decomposition
Aug 18, 2019
Merged

MAINT Remove the use of assert_raises* in decomposition#14679
thomasjpfan merged 7 commits intoscikit-learn:masterfrom
sameshl:mnt_tests_decomposition

Conversation

@sameshl
Copy link
Copy Markdown
Contributor

@sameshl sameshl commented Aug 18, 2019

Replaced assert_raises and assert_raises_regex with
the with pytest.raises context manager.

related to #14216

@thomasjpfan thomasjpfan changed the title MNT Remove the use of assert_raises and assert_raises_regex from decomposition/tests/ MAINT Remove the use of assert_raises* in decomposition Aug 18, 2019
@thomasjpfan thomasjpfan merged commit 35c0ca0 into scikit-learn:master Aug 18, 2019
@thomasjpfan
Copy link
Copy Markdown
Member

Thank you @sameshl !

@sameshl sameshl deleted the mnt_tests_decomposition branch August 18, 2019 17:34
@sameshl
Copy link
Copy Markdown
Contributor Author

sameshl commented Aug 18, 2019

Thank you @thomasjfox! Glad I could help!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants