Skip to content

MAINT:Fix assert raises in sklearn/compose/tests/#14670

Merged
thomasjpfan merged 3 commits intoscikit-learn:masterfrom
sameshl:compose_tests
Aug 17, 2019
Merged

MAINT:Fix assert raises in sklearn/compose/tests/#14670
thomasjpfan merged 3 commits intoscikit-learn:masterfrom
sameshl:compose_tests

Conversation

@sameshl
Copy link
Copy Markdown
Contributor

@sameshl sameshl commented Aug 16, 2019

replaced assert_raises and assert_raises_regex with pytest.raises context manager.

related to #14216

sameshl added 2 commits August 16, 2019 16:16
@sameshl
MAINT:Fix assert raises in sklearn/compose/tests/
eac0dba 
replaced `assert_raises` and `assert_raises_regex` with
the with `pytest.raises` context manager.

related to #14216
@sameshl
Remove the use of assert_raises and assert_raises_regex from `tes…
e072d70 
…t_target.py`
@thomasjpfan
Copy link
Copy Markdown
Member

thomasjpfan commented Aug 16, 2019

Run the following to see the lint errors locally:

make flake8-diff

@thomasjpfan thomasjpfan merged commit db23c4e into scikit-learn:master Aug 17, 2019
@thomasjpfan
Copy link
Copy Markdown
Member

thomasjpfan commented Aug 17, 2019

Thank you @sameshl!

@sameshl sameshl deleted the compose_tests branch August 17, 2019 09:32
@sameshl
Copy link
Copy Markdown
Contributor Author

sameshl commented Aug 17, 2019

Thank you @thomasjpfan

@sameshl sameshl mentioned this pull request Aug 21, 2019
Closed
43 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@thomasjpfan thomasjpfan thomasjpfan approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@sameshl @thomasjpfan