MAINT:Remove the use of assert_raises and assert_raises_regex#14645
Merged
thomasjpfan merged 1 commit intoscikit-learn:masterfrom Aug 14, 2019
sameshl:cluster_assert_raises
Merged
MAINT:Remove the use of assert_raises and assert_raises_regex#14645thomasjpfan merged 1 commit intoscikit-learn:masterfrom sameshl:cluster_assert_raises
thomasjpfan merged 1 commit intoscikit-learn:masterfrom
sameshl:cluster_assert_raises
Conversation
removed the use of assert_raises and assert_raises_regex from `sklearn/cluster/tests/test_hierarchical.py` changed `assert_raises` to `with pytest.raises` context manager
jnothman
approved these changes
Aug 13, 2019
thomasjpfan
approved these changes
Aug 14, 2019
Member
|
Thank you @sameshl! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
removed the use of assert_raises and assert_raises_regex
from
sklearn/cluster/tests/test_hierarchical.pychanged
assert_raisestowith pytest.raisescontext managerfixes #14216
I still have to complete the whole
sklearn/cluster/tests/folder. I just wanted to get a review if any other changes are required.Thanks!