Rewrite user-guide to clarify feature_importances_ are impurity based#14530
Rewrite user-guide to clarify feature_importances_ are impurity based#14530shahules786 wants to merge 4 commits intoscikit-learn:masterfrom
Conversation
|
@maverick100 Could you edit your original post adding the issue number to look at to see which issue you are solving. |
Yes,Done |
| The verbosity level | ||
|
|
||
| loss : string, optional | ||
| loss : string, optional (default="hinge") |
There was a problem hiding this comment.
Could you revert all the changes in this file? This is not related to this PR.
sklearn/tree/tree.py
Outdated
| The importance of a feature is computed as the (normalized) total | ||
| reduction of the criterion brought by that feature. | ||
| It is also known as the Gini importance. | ||
| We measure the importance of a feature by calculating |
There was a problem hiding this comment.
This is wrong. The docstring is correct here. The feature_importances_ is computed using the Gini importance.
What needs to be changed is the User Guide in which we need to change the occurrence feature importance by additional information mentioning that this is the Gini importance.
And as @amueller mentioned, whenever possible we should change our example or User Guide to use the feature importance based on random permutation instead.
…n importance" This reverts commit 8624e81.
|
Are you planning on working on this issue? The PR currently doesn't contain any relevant changes, so I suggest closing it, unless you're planning to add changes soon. |
Reference Issues/PRs
closes #14528
What does this implement/fix? Explain your changes.
Rewritten user-guide to clarify feature importance as permutation importance,including a small and precise explanation of how it is calculated.
Any other comments?