[MRG] fix convergence warning for plot_grid_search_refit_callable.py#14329
Closed
wendyhhu wants to merge 2 commits intoscikit-learn:masterfrom
Closed
[MRG] fix convergence warning for plot_grid_search_refit_callable.py#14329wendyhhu wants to merge 2 commits intoscikit-learn:masterfrom
wendyhhu wants to merge 2 commits intoscikit-learn:masterfrom
Conversation
Member
|
Failure on CI is unrelated to the changes |
thomasjpfan
reviewed
Jul 13, 2019
|
|
||
| The figure shows the trade-off between cross-validated score and the number | ||
| of PCA components. The balanced case is when n_components=6 and accuracy=0.80, | ||
| of PCA components. The balanced case is when n_components=12 and accuracy=0.90, |
Member
There was a problem hiding this comment.
In the generated docs, https://64501-843222-gh.circle-artifacts.com/0/doc/auto_examples/model_selection/plot_grid_search_refit_callable.html it generates:
The best_index_ is 2
The n_components selected is 10
The corresponding accuracy score is 0.88
Member
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
This work is built on top of #14143.
What does this implement/fix? Explain your changes.
Any other comments?