[WIP] FIX make sure sample_weight has an effect on predictions#14266
Closed
glemaitre wants to merge 1 commit intoscikit-learn:mainfrom
Closed
[WIP] FIX make sure sample_weight has an effect on predictions#14266glemaitre wants to merge 1 commit intoscikit-learn:mainfrom
glemaitre wants to merge 1 commit intoscikit-learn:mainfrom
Conversation
Member
|
Have you already checked why those estimators are failing? One would assume some of those failing estimators are definitely okay regarding sample weights, apparently not. |
Member
|
Not all weightings and data are going to affect every model... Despite
saying this is a necessary condition I'm not sure it's something we can put
in a common test.
|
Member
Author
I am looking at the different models which are failing to understand if this is normal or not. |
14 tasks
Member
|
We now have a common test to check sample_weight implementation, #30137. Let's close this one |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Alternative/complement to #14246
Check that
sample_weightchange the prediction of the estimator. In case this is not true, it could be because of a bug.