Skip to content

MNT CI change circleci docker image#13525

Closed
adrinjalali wants to merge 7 commits intoscikit-learn:masterfrom
adrinjalali:ci/circle-docker
Closed

MNT CI change circleci docker image#13525
adrinjalali wants to merge 7 commits intoscikit-learn:masterfrom
adrinjalali:ci/circle-docker

Conversation

@adrinjalali
Copy link
Copy Markdown
Member

@adrinjalali adrinjalali commented Mar 26, 2019

Changing to 3.7 to see if the 404 issue persists.

@adrinjalali
Copy link
Copy Markdown
Member Author

adrinjalali commented Mar 26, 2019

Seems working!

@adrinjalali
Copy link
Copy Markdown
Member Author

adrinjalali commented Mar 26, 2019

Now it fails because of a sphinx-gallery issue I guess.

@jnothman
Copy link
Copy Markdown
Member

jnothman commented Mar 26, 2019

I'm happy with this fix, but it would be nice to fix whatever other dependency issues here before merging :P)

@thomasjpfan
Copy link
Copy Markdown
Member

thomasjpfan commented Mar 26, 2019

Maybe it’s time to update our Sphinx version?

@adrinjalali
Copy link
Copy Markdown
Member Author

adrinjalali commented Mar 27, 2019

yeah, trying with the new sphinx, it doesn't fail locally for me. But I remember there were reasons for not doing it, let's see.

@adrinjalali
Copy link
Copy Markdown
Member Author

adrinjalali commented Mar 27, 2019

I'm trying to figure out the issue, but in the mean time, if somebody knows where this is coming from, I'd appreciate the help:

Traceback (most recent call last):
  File "/home/circleci/miniconda/envs/testenv/lib/python3.5/site-packages/sphinx/cmd/build.py", line 304, in build_main
    app.build(args.force_all, filenames)
  File "/home/circleci/miniconda/envs/testenv/lib/python3.5/site-packages/sphinx/application.py", line 341, in build
    self.builder.build_update()
  File "/home/circleci/miniconda/envs/testenv/lib/python3.5/site-packages/sphinx/builders/__init__.py", line 347, in build_update
    len(to_build))
  File "/home/circleci/miniconda/envs/testenv/lib/python3.5/site-packages/sphinx/builders/__init__.py", line 412, in build
    self.write(docnames, list(updated_docnames), method)
  File "/home/circleci/miniconda/envs/testenv/lib/python3.5/site-packages/sphinx/builders/__init__.py", line 593, in write
    self._write_serial(sorted(docnames))
  File "/home/circleci/miniconda/envs/testenv/lib/python3.5/site-packages/sphinx/builders/__init__.py", line 601, in _write_serial
    doctree = self.env.get_and_resolve_doctree(docname, self)
  File "/home/circleci/miniconda/envs/testenv/lib/python3.5/site-packages/sphinx/environment/__init__.py", line 627, in get_and_resolve_doctree
    self.apply_post_transforms(doctree, docname)
  File "/home/circleci/miniconda/envs/testenv/lib/python3.5/site-packages/sphinx/environment/__init__.py", line 674, in apply_post_transforms
    transformer.apply_transforms()
  File "/home/circleci/miniconda/envs/testenv/lib/python3.5/site-packages/sphinx/transforms/__init__.py", line 90, in apply_transforms
    Transformer.apply_transforms(self)
  File "/home/circleci/miniconda/envs/testenv/lib/python3.5/site-packages/docutils/transforms/__init__.py", line 171, in apply_transforms
    transform.apply(**kwargs)
  File "/home/circleci/miniconda/envs/testenv/lib/python3.5/site-packages/sphinx/transforms/post_transforms/images.py", line 42, in apply
    self.handle(node)
  File "/home/circleci/miniconda/envs/testenv/lib/python3.5/site-packages/sphinx/transforms/post_transforms/images.py", line 264, in handle
    if self.convert(abs_srcpath, destpath):
  File "/home/circleci/miniconda/envs/testenv/lib/python3.5/site-packages/sphinx/ext/imgconverter.py", line 96, in convert
    (stderr, stdout))
sphinx.errors.ExtensionError: convert exited with error:
[stderr]
b"convert-im6.q16: unable to read font `(null)' @ error/annotate.c/RenderFreetype/1362.\nconvert-im6.q16: non-conforming drawing primitive definition `text' @ error/draw.c/DrawImage/3265.\n"
[stdout]
b''

Extension error:
convert exited with error:
[stderr]
b"convert-im6.q16: unable to read font `(null)' @ error/annotate.c/RenderFreetype/1362.\nconvert-im6.q16: non-conforming drawing primitive definition `text' @ error/draw.c/DrawImage/3265.\n"
[stdout]
b''
Makefile:52: recipe for target 'html-noplot' failed
make: *** [html-noplot] Error 2
Exited with code 2

@adrinjalali adrinjalali mentioned this pull request Mar 27, 2019
Closed
@lesteve
Copy link
Copy Markdown
Member

lesteve commented Mar 27, 2019

@adrinjalali If I were you I would switch to circleci/python3.6 this docker image uses Debian stretch (rather than Debian jessie which is the source of the 404 errors) and should get the build to pass with little additional modification.

@lesteve
Copy link
Copy Markdown
Member

lesteve commented Mar 27, 2019

I actually pushed the simple fix in #13527, this way we can make sure that CircleCI is green again in #13527 with the sphinx-gallery + Debian stretch fixes.

@adrinjalali
Copy link
Copy Markdown
Member Author

adrinjalali commented Mar 27, 2019

I actually pushed the simple fix in #13527, this way we can make sure that CircleCI is green again in #13527 with the sphinx-gallery + Debian stretch fixes.

Awesome, thanks. But I'm still curious why this is failing. I'll try upgrading the sphinx once [hopefully] your PR gets in.

@lesteve
Copy link
Copy Markdown
Member

lesteve commented Mar 27, 2019

Awesome, thanks. But I'm still curious why this is failing.

Looking at the traceback it seems like this is related to a convert (as in the command-line tool convert from ImageMagick). You can use the sphinx-build -P flag to enter pdb and figure out which file it is trying to convert, i.e. something like this (run from the doc folder):

sphinx-build -b html -d _build/doctrees    . _build/html/stable -P

It could well be that it is because of an update in Debian and that #13527 will get the same issue ...

@lesteve
Copy link
Copy Markdown
Member

lesteve commented Mar 27, 2019 •
edited
Loading

It could well be that it is because of an update in Debian and that #13527 will get the same issue ...

Yep same issue on #13527 I'll investigate further. Edit: not exactly the same but very similar (see e.g. https://circleci.com/gh/scikit-learn/scikit-learn/53008)

@rth rth mentioned this pull request Mar 27, 2019
Merged
2 tasks
@adrinjalali
Copy link
Copy Markdown
Member Author

adrinjalali commented Mar 27, 2019

looks pretty okay (example: https://53109-843222-gh.circle-artifacts.com/0/doc/modules/decomposition.html#pca), are we interested in moving up the sphinx version?

@rth
Copy link
Copy Markdown
Member

rth commented Jun 11, 2019

are we interested in moving up the sphinx version?

Why not. But the rest of the diff here looks unrelated (maybe due to the merge conflict)?

@thomasjpfan
Copy link
Copy Markdown
Member

thomasjpfan commented Jun 12, 2019

Lets not update it here. sphinx 2.0 uses different html elements which needs the CSS to be updated: #13982

@rth
Copy link
Copy Markdown
Member

rth commented Jun 20, 2019 •
edited
Loading

Lets not update it here. sphinx 2.0 uses different html elements which needs the CSS to be updated:

@thomasjpfan OK, should we close this then?

@adrinjalali
Copy link
Copy Markdown
Member Author

adrinjalali commented Jun 20, 2019

closing since #13982 fixes this as well.

@adrinjalali adrinjalali deleted the ci/circle-docker branch June 20, 2019 17:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@adrinjalali @jnothman @thomasjpfan @lesteve @rth