[WIP] Change default convergence params for classes using liblinear (LinearSVM and LogisticRegression)#13317
Draft
summer-bebop wants to merge 3 commits intoscikit-learn:mainfrom
Draft
Conversation
…ams of LinearSV{C,R} and LogisticRegression
Contributor
Author
|
@GaelVaroquaux @agramfort All right after several checks I noticed that all solver libraries already have their own default on max_iter and tol (I do have a doubt about the default of max_iter in liblinear though). Hence I suggest the following strategie :
What do you think ? -> just implement a function called in the .fit that maps solvers to tol and max_iter On another subject I see that besides lbfgs, the tol for liblinear, newton-cg are also related to the value of the gradient of the function and not to value of the function. So while I can change that for lbfgs as scipy also expose an ftol, newton-cg and liblinear don't. There is probably some room for improvement there ? |
… the solver. Todo : branching detail for liblinear to select the internal solver, tests for auto value in max_iter and tol for logisticreg and linearsvm, benchmarks to check if solvers default are good, change lbfgs tol for an ftol instead of a pgtol
…benchmarks to check if solvers defaults are good, change lbfgs tol for an ftol instead of a pgtol
Member
|
What's the status on this? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
Fixes #11536
What does this implement/fix? Explain your changes.
This Pull request is meant to implement an automatic determination of the value of convergence parameters (max_iter and tol).
TODO