added note that partial_fit often only performs a single iteration #12806#12836
Closed
fdas3213 wants to merge 2 commits intoscikit-learn:masterfrom
Closed
added note that partial_fit often only performs a single iteration #12806#12836fdas3213 wants to merge 2 commits intoscikit-learn:masterfrom
fdas3213 wants to merge 2 commits intoscikit-learn:masterfrom
Conversation
Member
|
Please edit the glossary, not a particular estimator docstring. doc/glossary.rst |
Contributor
Author
Thanks for letting me know. I'll do that right away |
jnothman
reviewed
Dec 23, 2018
| provided to ``partial_fit`` may be called a mini-batch. | ||
| Each mini-batch must be of consistent shape, etc. | ||
| Each mini-batch must be of consistent shape, etc. It should also be | ||
| noted that partial_fit often only performs a single iteration. |
Member
There was a problem hiding this comment.
and please follow the indentation: use spaces.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
This PR refers to the issue 'Glossary on partial_fit should note that it often only performs a single iteration' #12806
What does this implement/fix? Explain your changes.
This PR adds a note that partial_fit often only performs a single iteration
Any other comments?