MNT simple deprecations and removals for 0.21#12238
MNT simple deprecations and removals for 0.21#12238amueller merged 12 commits intoscikit-learn:masterfrom
Conversation
|
This pull request introduces 17 alerts and fixes 2 when merging c56c2af into 59b15c5 - view on LGTM.com new alerts:
fixed alerts:
Comment posted by LGTM.com |
|
This pull request introduces 17 alerts and fixes 2 when merging cd48d6d into 59b15c5 - view on LGTM.com new alerts:
fixed alerts:
Comment posted by LGTM.com |
|
This pull request fixes 2 alerts when merging 5069dcf into 59b15c5 - view on LGTM.com fixed alerts:
Comment posted by LGTM.com |
|
This pull request fixes 2 alerts when merging cfa9216 into 7166cd5 - view on LGTM.com fixed alerts:
Comment posted by LGTM.com |
|
This pull request fixes 2 alerts when merging 45289e8 into dfd009d - view on LGTM.com fixed alerts:
Comment posted by LGTM.com |
rth
left a comment
There was a problem hiding this comment.
LGTM, nice to remove all this code! Only checked what's included though, if anything is missing it could be worth doing a follow up PR.
|
This pull request fixes 2 alerts when merging 3afc42b into dfd009d - view on LGTM.com fixed alerts:
Comment posted by LGTM.com |
|
This pull request fixes 2 alerts when merging 84d6cf3 into 63e5ae6 - view on LGTM.com fixed alerts:
Comment posted by LGTM.com |
jnothman
left a comment
There was a problem hiding this comment.
I'm not checking that these are unused/undocumented. Let's hope that was done at time of deprecation. The code changes seem sound.
|
should I merge now? Should be fine, right? Or wait for 0.20.1? I don't think it should conflict too much? |
|
I doubt it should affect 0.20.1. (Though we do need to get onto making that release happen sooner rather than later.) |
Part of #11992.
These were all the things that seemed pretty straight-forward. It's actually a bit bulky but should still be easy to review, hopefully.