Reword to avoid that people draw wrong conclusions#12095
Merged
jnothman merged 1 commit intoscikit-learn:masterfrom Sep 17, 2018
Merged
Reword to avoid that people draw wrong conclusions#12095jnothman merged 1 commit intoscikit-learn:masterfrom
jnothman merged 1 commit intoscikit-learn:masterfrom
Conversation
1. OPTICS is not "equivalent" to DBSCAN (then we would not need it), just related / more general / enhanced. 2. OPTICS is not (and cannot) be more scalable than DBSCAN; the problem is the current sklearn implementation of DBSCAN that needs a lot of memory (and this could change).
TomDLT
approved these changes
Sep 17, 2018
jnothman
approved these changes
Sep 17, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
What does this implement/fix? Explain your changes.
Any other comments?