Skip to content

[wip] replicate lobpcg instabilities#11965

Closed
massich wants to merge 2 commits intoscikit-learn:masterfrom
massich:replicate_10278
Closed

[wip] replicate lobpcg instabilities#11965
massich wants to merge 2 commits intoscikit-learn:masterfrom
massich:replicate_10278

Conversation

@massich
Copy link
Copy Markdown
Contributor

@massich massich commented Sep 1, 2018

Reference Issues/PRs

#10278

What does this implement/fix? Explain your changes.

Any other comments?

@glemaitre glemaitre changed the title [wip] replicate lobpcg instavilities [wip] replicate lobpcg instabilities Sep 1, 2018
@glemaitre
Copy link
Copy Markdown
Member

We also need to solve #10715 actually.

xx.append(spectral_clustering(graph, n_clusters=2,
eigen_solver=solver, random_state=seed))

assert_array_equal(xx[0], xx[1])
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cluster assignments can be arbitrary (see also the failed test reports). Consider using adjusted_rand_score or other cluster similarity e.g.:
adjusted_rand_score(xx[0], xx[1]) == pytest.approx(1)

@amueller
Copy link
Copy Markdown
Member

amueller commented Aug 5, 2019

original issue has been closed.

@amueller amueller closed this Aug 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants