WIP: Migrate to Cython memoryviews in sklearn.utils#11964
WIP: Migrate to Cython memoryviews in sklearn.utils#11964rth wants to merge 3 commits intoscikit-learn:masterfrom
Conversation
|
After investigating with @lesteve it turns out the tests were not failing because Once that is fixed in #11966, this PR will not work unfortunately due to #10624 (comment) :/ |
|
Or more explicitly it would be necessary to fix cython/cython#1772 to make this possible |
|
FWIW |
Yes, but than we get the overhead of a copy in the hope of gaining something when transitioning to memoryviews. Generally the goal of this PR was to check whether we could easily use memoryviews. We cant (except for workarounds you mentioned) until the corresponding Cython issue is fixed. Closing this for now. |
This aims migrate
sklearn.utilsfrom the numpy buffer interface in cython to memoryviews.Addresses part of #10624
Also added a tests make sure we are not in the case #10624 (comment)
WDYT @lesteve ?