[WIP] Additional Warnings in case OpenML auto-detected a problem with dataset#11873
Closed
janvanrijn wants to merge 1 commit intoscikit-learn:masterfrom
janvanrijn:add_#11872
Closed
[WIP] Additional Warnings in case OpenML auto-detected a problem with dataset#11873janvanrijn wants to merge 1 commit intoscikit-learn:masterfrom janvanrijn:add_#11872
janvanrijn wants to merge 1 commit intoscikit-learn:masterfrom
janvanrijn:add_#11872
Conversation
jnothman
reviewed
Aug 21, 2018
Member
jnothman
left a comment
There was a problem hiding this comment.
I suppose this is okay. Ideally we should add a test.
rth
reviewed
Nov 5, 2018
Member
rth
left a comment
There was a problem hiding this comment.
Could you please add a test @janvanrijn , otherwise looks good.
jnothman
approved these changes
Nov 6, 2018
Member
|
I wouldn't mind adding a test with a mock HTTP response just to ensure the line is tested (and so the behaviour does not get corrupted in the future) |
Contributor
Author
|
I completely forgot about this PR, and even deleted the repository from which it was created (github problems, my fault) I will open a new one, referencing to this PR. |
This was referenced Nov 7, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #11872