[MRG] Check dataframe columns names for StandardScaler methods#11607
Closed
NicolasHug wants to merge 2 commits intoscikit-learn:masterfrom
Closed
[MRG] Check dataframe columns names for StandardScaler methods#11607NicolasHug wants to merge 2 commits intoscikit-learn:masterfrom
NicolasHug wants to merge 2 commits intoscikit-learn:masterfrom
Conversation
Member
|
Not sure if you heard the discussion earlier but I'll write a proposal for this. It's good to have the implementation, though. |
jnothman
reviewed
Jul 18, 2018
Member
jnothman
left a comment
There was a problem hiding this comment.
This is quite nice, the biggest problem being that it adds additional validation to every estimator, where perhaps it should be replacing check_X_y with a stateful version on the class.
Member
Author
|
Closing, supersedded by many stuff (n_features_in_ and subsequent checks) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
This addresses #7242 for the StandardScaler class. This goal of this PR is to evaluate how many changes would be needed to completely fix #7242.
What does this implement/fix? Explain your changes.
This PR adds the
_check_column_namesmethod toBaseEstimatorand uses it inStandardScaler._check_column_namesis a helper to verify that the dataframes passed as input to fit(), predict(), transform() (etc.) have the same column names. This prevents user issues (#7242)Any other comments?
I definitely don't have a sufficiently clear overview of the whole project to be certain, but the changes to the estimators code seem relatively small: only a line here and there.
cc @amueller