[MRG+1] Fix bad fp-comparisons#11591
Merged
GaelVaroquaux merged 4 commits intoscikit-learn:masterfrom Jul 18, 2018
Merged
Conversation
qinhanmin2014
approved these changes
Jul 17, 2018
Member
qinhanmin2014
left a comment
There was a problem hiding this comment.
I'm fine with merging without a test.
|
|
||
| # disabling joblib as the pickling of large dicts seems much too slow | ||
| #@memory.cache | ||
| # @memory.cache |
Member
There was a problem hiding this comment.
We've decided not to fix existing flake8 errors.
Member
Author
There was a problem hiding this comment.
Ok sorry. What the reason behind that ?
| dangle = np.asarray(np.where(X.sum(axis=1) == 0, 1.0 / n, 0)).ravel() | ||
| dangle = np.asarray(np.where(np.isclose(X.sum(axis=1), 0), | ||
| 1.0 / n, | ||
| 0)).ravel() |
Member
There was a problem hiding this comment.
don't need an extra line here?
|
|
||
| return scores | ||
|
|
||
|
|
Member
There was a problem hiding this comment.
please avoid unnecessary changes.
qinhanmin2014
approved these changes
Jul 18, 2018
Member
qinhanmin2014
left a comment
There was a problem hiding this comment.
LGTM, I'll try to mark it as 0.20.
GaelVaroquaux
approved these changes
Jul 18, 2018
Member
GaelVaroquaux
left a comment
There was a problem hiding this comment.
LGTM. Thank you
Merging
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #11551
changed exact comparison with between float values by np.isclose where needed.
-> np.asarray(np.where(X.sum(axis=1) == 0, 1.0 / n, 0)).ravel()
edit: removed 2. They were in cython functions, within nogil statement.