[MRG+2] FIX: make the deprecation in fit and not init in IsolationForest#11574
Merged
amueller merged 3 commits intoscikit-learn:masterfrom Jul 17, 2018
Merged
[MRG+2] FIX: make the deprecation in fit and not init in IsolationForest#11574amueller merged 3 commits intoscikit-learn:masterfrom
amueller merged 3 commits intoscikit-learn:masterfrom
Conversation
Member
|
looks good |
amueller
approved these changes
Jul 16, 2018
qinhanmin2014
approved these changes
Jul 17, 2018
Member
qinhanmin2014
left a comment
There was a problem hiding this comment.
We also need to update the docstring of contamination
Contributor
|
LGTM. Thanks @glemaitre. Travis failure does not seem to be related to this PR. |
TomDLT
approved these changes
Jul 17, 2018
albertcthomas
approved these changes
Jul 17, 2018
Member
Author
|
What do you mean by updating the docstring |
Member
|
Seems that the docstring of parameter contamination fails to mention the change. |
Member
Author
|
oh I see
…On 17 July 2018 at 16:24, Hanmin Qin ***@***.***> wrote:
Seems that the docstring of parameter contamination fails to mention the
change.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#11574 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AHG9P-fPqCE38nMAEeI4XKZmBJTjfmzmks5uHfOegaJpZM4VR6LG>
.
--
Guillaume Lemaitre
INRIA Saclay - Parietal team
Center for Data Science Paris-Saclay
https://glemaitre.github.io/
|
qinhanmin2014
approved these changes
Jul 17, 2018
Member
Author
|
We cannot merge this PR now. There is a strange side effect with ignore_warning and filterwarnings I think. |
Member
Author
|
Ok it passed on my forked CI |
Member
Author
lesteve
reviewed
Jul 17, 2018
| assert_array_almost_equal(intercept2, clf.intercept_, decimal=9) | ||
|
|
||
|
|
||
| @ignore_warnings |
Member
There was a problem hiding this comment.
I really do not get this weird side-effect at a distance kind of thing ... it feels like something is really fishy here. I'll try to reproduce locally.
Member
|
travis passes. should we wait for the rest? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #11573
Rework IsolationForest issue