Skip to content

[MRG] import optics function in cluster.__init__#11567

Merged
qinhanmin2014 merged 2 commits intoscikit-learn:masterfrom
amueller:optics_func_import
Jul 17, 2018
Merged

[MRG] import optics function in cluster.__init__#11567
qinhanmin2014 merged 2 commits intoscikit-learn:masterfrom
amueller:optics_func_import

Conversation

@amueller
Copy link
Copy Markdown
Member

Cleanup after #1984: optics function interfaces is in classes.rst but not imported in cluster/__init__.py

@amueller amueller changed the title import optics function in cluster.__init__ [MRG] import optics function in cluster.__init__ Jul 16, 2018
Copy link
Copy Markdown
Member

@jorisvandenbossche jorisvandenbossche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apart from that I would rather name the module _optics instead of optics_ (which was rather a comment for the previous PR), this is certainly good to merge

Copy link
Copy Markdown
Member

@qinhanmin2014 qinhanmin2014 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thx @amueller

@qinhanmin2014 qinhanmin2014 merged commit db3b84e into scikit-learn:master Jul 17, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants