[MRG] TST Use fixed random state to avoid test failure of test_weighted_vs_repeated#11523
Merged
jnothman merged 1 commit intoscikit-learn:masterfrom Jul 16, 2018
qinhanmin2014:kmeans-test
Merged
[MRG] TST Use fixed random state to avoid test failure of test_weighted_vs_repeated#11523jnothman merged 1 commit intoscikit-learn:masterfrom qinhanmin2014:kmeans-test
jnothman merged 1 commit intoscikit-learn:masterfrom
qinhanmin2014:kmeans-test
Conversation
jnothman
approved these changes
Jul 16, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #11236
Implement the solution proposed by @jnothman and @ogrisel (I also agree with it)
I tried seed from 0 to 999, the test only fails when using
np.random.seed(973)Since we've used a fixed random state, I keep the check for v_measure.