FIX: attempt to fix pickling backward compat#11403
Closed
GaelVaroquaux wants to merge 1 commit intoscikit-learn:masterfrom
Closed
FIX: attempt to fix pickling backward compat#11403GaelVaroquaux wants to merge 1 commit intoscikit-learn:masterfrom
GaelVaroquaux wants to merge 1 commit intoscikit-learn:masterfrom
Conversation
The import path of numpy_pickle should be unchanged for backward compatibility.
|
This pull request introduces 2 alerts when merging d3df33c into 5916d57 - view on LGTM.com new alerts:
Comment posted by LGTM.com |
Member
|
Unfortunately I don't think this fixes the pickle backward compatibility problem, see #11166 (comment) for more details. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The import path of numpy_pickle should be unchanged for backward
compatibility.
This attempts to fix a regression introduced in #11166