[MRG] ENH: Add partial fit support to Pipeline#11321
Closed
stsievert wants to merge 4 commits intoscikit-learn:masterfrom
Closed
[MRG] ENH: Add partial fit support to Pipeline#11321stsievert wants to merge 4 commits intoscikit-learn:masterfrom
stsievert wants to merge 4 commits intoscikit-learn:masterfrom
Conversation
jnothman
reviewed
Jun 20, 2018
Member
jnothman
left a comment
There was a problem hiding this comment.
I think it will take time to reach consensus on this, so again, I don't think it fits into the current release.
| def partial_fit(self, X, y, **fit_params): | ||
| """Partially fit the model | ||
|
|
||
| Fit all the transforms one after the other and transform the |
Member
There was a problem hiding this comment.
Are you sure we should be fitting all the transformers again on this sample??
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
I'd like to see implemented for an adaptive parameter selection scheme that depends on
partial_fit, dask/dask-searchcv#72.This will also allow pipelines to work with
dask_ml.Incremental, a class that wraps models that implementpartial_fit.This also resolves #3299.
What does this implement/fix? Explain your changes.
This implements
Pipeline.partial_fit. It adds a new keyword argumentpartially_fit=[]toPipeline.__init__. If changed from default it should take in a list of names to callpartial_fiton.