[WIP] API: allow cross validation to work with partial_fit#11266
Open
stsievert wants to merge 7 commits intoscikit-learn:mainfrom
Open
[WIP] API: allow cross validation to work with partial_fit#11266stsievert wants to merge 7 commits intoscikit-learn:mainfrom
stsievert wants to merge 7 commits intoscikit-learn:mainfrom
Conversation
Member
|
Thanks. this can't possibly make it into v0.20 in my opinion. Indeed, it
would be great to be pinged after that release
|
This was referenced Jun 15, 2018
Contributor
Author
|
I think this is ready for review. On |
5 tasks
Contributor
Author
|
I'd like this to work better with repeated calls and the train/test split. That's where the main advantage comes from. |
This was referenced Jun 21, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
Addresses (but doesn't fix) #1626: "API Proposal: Genearlized Cross-Validation and Early Stopping". This PR only address early stopping on models that have
partial_fit(#1626 (comment)), not addressing "when more computation doesn't improve the result." (#1626 (comment)).I will use this in dask/dask-searchcv#72. Briefly, I want to repeatedly use
cross_validatewith a specified number ofpartial_fitcalls.What does this implement/fix? Explain your changes.
This PR implements early stopping for cross validation when
partial_fitis present. This requires that_fit_and_scorehave apartial_fitkeyword argument that can either be a bool or an int that reflects the number of timesest.partial_fitis called.partial_fitkeyword arg tocross_validate, which relies on_fit_and_score._fit_and_scoreis called repeatedly.TODO
make work with pipelinesintegrate with GridSearchCV and RandomizedSearchCV