[MRG] [RFC] multiclass and types_of_target#11213
[MRG] [RFC] multiclass and types_of_target#11213massich wants to merge 17 commits intoscikit-learn:masterfrom
Conversation
1a73583 to
cb57d0a
Compare
|
Do you think that this is understandable? |
cb57d0a to
b2d9563
Compare
|
It looks reasonable, but a lot of the information is redundant with the glossary section on target types. So perhaps it makes more sense to refer the reader there for details on formats and APIs. |
|
To refer to the glossary, you should use the |
efb307b to
15da70a
Compare
|
in a conversation at scipy2018, @ivanov suggested that maybe the problem for rewording the multiclass was that the examples were not the 'same' for all the scenarios. So here's a draft. I'm not really sure that all the examples make sense or are clear enough. So, comments are welcome!! If anyone can think of a different set of coherent examples, don't be shy. here's the artifact https://27909-843222-gh.circle-artifacts.com/0/doc/modules/multiclass.html |
|
IMO, I find that the changes make the documentation hard to read (too much level of bullet points) |
15da70a to
b17598a
Compare
|
@lucyleeow can you give it a read? and we finish it |
|
This is the current master https://scikit-learn.org/stable/modules/multiclass.html |
|
here is the last version https://29571-843222-gh.circle-artifacts.com/0/doc/modules/multiclass.html |
| for each data-point, such as wind direction and magnitude at a | ||
| certain location. | ||
| - valid :term:`multiclass` representation for | ||
| :func:`~utils.multiclass.type_of_target` (`y`) are: |
There was a problem hiding this comment.
This should be clickable and point to https://scikit-learn.org/stable/modules/generated/sklearn.utils.multiclass.type_of_target.html#sklearn.utils.multiclass.type_of_target
|
@massich it's still failing - but this may be because master is broken? |
|
Yes, CI still fails on master cf #14956 (comment) . We need to investigate it. |
|
Closing in favor of #15333 since @lucyleeow did a great job! |
Reference Issues/PRs
fixes #9777
What does this implement/fix? Explain your changes.
Any other comments?
This PR should be entered before #9059