[WIP] FIX: use maxiter rather than maxfun in MultiLayerPerceptron with solver='lbfgs'#10724
Closed
lesteve wants to merge 2 commits intoscikit-learn:masterfrom
Closed
[WIP] FIX: use maxiter rather than maxfun in MultiLayerPerceptron with solver='lbfgs'#10724lesteve wants to merge 2 commits intoscikit-learn:masterfrom
lesteve wants to merge 2 commits intoscikit-learn:masterfrom
Conversation
Member
|
cf. #9273 |
Member
Author
|
I am going to set this to WIP because I am not so convinced this is a problem. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In my limited experience with LBFGS, the number of function calls is greater than the number of iterations.
The impact of this bug is that with solver='lbfgs' is probably not doing as many iterations as it should in master although I am not sure it matters that much in practice.
To get an idea how much funtion calls differ from iterations, I tweaked
examples/neural_networks/plot_mnist_filters.pyto be able to run for a few hundred iterations:The result: 393 iterations and 414 function calls.
Not sure whether we nest to test this, and how to test it, suggestions more than welcome!