[MRG+1] Use almost minimal dependencies in Python 2 build on CircleCI#10627
Merged
lesteve merged 3 commits intoscikit-learn:masterfrom Feb 13, 2018
Merged
Conversation
c0c3238 to
5575fa6
Compare
Member
|
Failures |
5575fa6 to
b950da2
Compare
qinhanmin2014
approved these changes
Feb 13, 2018
Member
qinhanmin2014
left a comment
There was a problem hiding this comment.
LGTM, personally I might prefer a note in plot_gpc_xor.py to tell users this requires scipy>=0.14.
Member
Author
|
Merging this one.
@qinhanmin2014 the fact that no one has reported the problem so far leads me to believe that the intersection of users using scipy <= 0.13.3 and the users running this example is very small. A PR adding a rst warning in the example would be more than welcome. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a continuation of #10557 (that was reverted because examples/gaussian_process/plot_gpc_xor.py fails on scipy 0.13.3) so that we run the examples with versions that are as close as possible to the minimal required versions.