Fix Feature Request: Gaussian adjust option in RobustScaler #10139#10140
Closed
mabelvj wants to merge 1 commit intoscikit-learn:masterfrom
Closed
Fix Feature Request: Gaussian adjust option in RobustScaler #10139#10140mabelvj wants to merge 1 commit intoscikit-learn:masterfrom
mabelvj wants to merge 1 commit intoscikit-learn:masterfrom
Conversation
c3d51fb to
9db3b6d
Compare
9db3b6d to
ab75871
Compare
Member
|
Sorry for no reply :( could you add a test that shows that this option makes StandardScaler and RobustScaler equivalent on normal data? |
Contributor
|
Closed as finalized in #17193. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I made some changes in the function to implement gauss_adjust following the request in the thread Feature Request: Gaussian adjust option in RobustScaler #10139.
There is a new optional input parameter for RobustScaler called gauss_adjust. If gauss_adjust is set to True, the scale will be adjusted so the distribution of the output feature has std = 1. By default, gauss_adjust is set to False.
Also built the package and run the tests.
I'm new in open source projects, so let me know if there are any more steps I should follow.