-
-
Notifications
You must be signed in to change notification settings - Fork 26.9k
check_estimator should allow NaNs? #7737
Copy link
Copy link
Closed
Description
In imbalanced-learn we have cases (e.g. scikit-learn-contrib/imbalanced-learn#157) where some samplers like RandomUnderSampler and RandomOverSampler could naturally accept NaNs for X because the values of the X are irrelevant to the random sampling itself. If we modifiy the Random*Samplers to accept NaNs the check_estimator tests fall for them.
So we have two options:
- Skip the
check_estimatortests for theRandom*Samplers - Do not accept the
NaNsat all and document it clearly.
Any workaround on this? What are your thoughts?
This issue in general is related to #6981.
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
No labels