-
-
Notifications
You must be signed in to change notification settings - Fork 26.9k
VBGMM mutates alpha in __init__ #5547
Copy link
Copy link
Closed
Labels
BugEasyWell-defined and straightforward way to resolveWell-defined and straightforward way to resolve
Description
We should probably fix this. this means set_params was broken.
I think an easy fix that doesn't break backward compatibility would be:
introduce a property _alpha = alpha / n_components and then use _alpha instead of alpha everywhere.
That would mean behavior stays the same for people not using set_params / clone.
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
BugEasyWell-defined and straightforward way to resolveWell-defined and straightforward way to resolve