-
-
Notifications
You must be signed in to change notification settings - Fork 26.9k
factorize common tests #406
Copy link
Copy link
Closed
Labels
EasyWell-defined and straightforward way to resolveWell-defined and straightforward way to resolveEnhancement
Description
Easy:
- in test_common, check that the ValueError raise has a useful error message. (see sparse test for an example)
- put as many of the "specific" tests in test_clustering, test_transformers, ... into test_non_meta_estimators.
Not so easy:
- calling
fitforgets the previous model if any check how classifiers handle only one class being presenttest how models handle non-float input (does uint8 cause overflows?)
Things done
We should factorize common tests in a new file test_common.py (or maybe test_input.py?). Things to check:
can pickle the objectraise an exception when data contains nansraise an exception for invalid input (e.g.,np.matrixorsp.csr_matrixif dense only implementation)raise an exception ifn_featuresis not the same infitandpredictortransform__repr__andcloneworkcheck that we can pickle and unpickle estimators.check that all classifiers have aclasses_attribute (needs some fixes)
Edit by @amueller!
Edit by @GaelVaroquaux on Aug 13th 2014 to reflect progress in the codebase.
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
EasyWell-defined and straightforward way to resolveWell-defined and straightforward way to resolveEnhancement