-
-
Notifications
You must be signed in to change notification settings - Fork 26.9k
Document/standardize how to skip network tests #16750
Copy link
Copy link
Open
Labels
Description
Following discussion in #16743 I think it would be good to document and standardize how we skip tests that require network or download (this could also apply to tests that are skipped for other reason). Currently there are these mechanisms,
SKLEARN_SKIP_NETWORK_TESTSfor some testsnetworkpytest marker for other tests, meaning that such tests can be deselected with-m "not network"pytest option- also the
--skip-networkpytest option, that skips tests with thenetworkmarker. The issue with this is that it requires aconftests.py, which is currently not available e.g. when scikit-learn is installed and tests are run withpytest --pyargs sklearn.
I would propose to remove 1, and standardize/document the use of either 2 or 3. If we go with 3 we might need to move conftests.py under the sklearn folder, although it's also not ideal.
Reactions are currently unavailable