Skip to content

RandomTreesEmbedding __init__ doesn't satisfy API #12290

@amueller

Description

@amueller

via #8022.

RandomTreesEmbedding set's 'criterion' and 'max_features' even though they are not init parameters.
Two possible work-arounds: Either make them init parameters (allowing the user to make it not be actually completely random), or adding these two to BaseForest, which would also pacify our tests.

Suggestions?

Metadata

Metadata

Assignees

No one assigned

    Labels

    EasyWell-defined and straightforward way to resolvegood first issueEasy with clear instructions to resolvehelp wanted

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions