-
-
Notifications
You must be signed in to change notification settings - Fork 26.9k
RandomTreesEmbedding __init__ doesn't satisfy API #12290
Copy link
Copy link
Closed
Labels
EasyWell-defined and straightforward way to resolveWell-defined and straightforward way to resolvegood first issueEasy with clear instructions to resolveEasy with clear instructions to resolvehelp wanted
Description
via #8022.
RandomTreesEmbedding set's 'criterion' and 'max_features' even though they are not init parameters.
Two possible work-arounds: Either make them init parameters (allowing the user to make it not be actually completely random), or adding these two to BaseForest, which would also pacify our tests.
Suggestions?
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
EasyWell-defined and straightforward way to resolveWell-defined and straightforward way to resolvegood first issueEasy with clear instructions to resolveEasy with clear instructions to resolvehelp wanted