[MRG] Move RandomTreesEmbedding criterion & max_features to be class attributes (#12324)

rohan-varma · amueller · commit 39bd736e5954 · 2018-10-10T15:56:47.000-04:00
* rm criterion and max_features from __init__ and store them as class attrs instead

* make sure that the docstring comes first
diff --git a/sklearn/ensemble/forest.py b/sklearn/ensemble/forest.py
@@ -1896,6 +1896,9 @@ class RandomTreesEmbedding(BaseForest):
 
     """
 
+    criterion = 'mse'
+    max_features = 1
+
     def __init__(self,
                  n_estimators='warn',
                  max_depth=5,
@@ -1925,12 +1928,10 @@ def __init__(self,
             verbose=verbose,
             warm_start=warm_start)
 
-        self.criterion = 'mse'
         self.max_depth = max_depth
         self.min_samples_split = min_samples_split
         self.min_samples_leaf = min_samples_leaf
         self.min_weight_fraction_leaf = min_weight_fraction_leaf
-        self.max_features = 1
         self.max_leaf_nodes = max_leaf_nodes
         self.min_impurity_decrease = min_impurity_decrease
         self.min_impurity_split = min_impurity_split
