Merged
Conversation
mkcor
approved these changes
Jan 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This updates docstub to the most recent version: 0.6.0. I've allowed for patch releases but excluded >=0.7.0, because those might introduce new features. By pinning we can more closely control our CI.
After the discussion during our summit I removed the skimage specific array syntax (scientific-python/docstub@9d546a8). We opted to adopt the less ambiguous one from scikit-learn.
This is the reason the number of reported errors goes up. There'll be many more expression that docstub doesn't allow. I recommend addressing these in a separate PR. So it's clearer how the allowed number of errors changes.
This was brought up in #8011 (comment).
@mkcor feel free to merge this if you approve.
Checklist
./doc/examplesfor new featuresRelease note
For maintainers and optionally contributors, please refer to the instructions on how to document this PR for the release notes.