Move away from numpy.fix in favor of numpy.trunc #7933
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hmaarrfk
approved these changes
Nov 9, 2025
Contributor
Author
|
I looked at the failing check, but it looks unrelated; I’m not sure how to best read it, though. Is this a known flaky test or should I look more deeply (pardon my ignorance)? |
Member
|
I think I've seen that one before and its unrelated. It's a pytest warning about an unclosed file buffer somewhere. I already looked into it at some point but didn't find the culprit. I'll open an issue for it. |
Member
|
Oh, and I think the PR title is enough in terms of release notes. We only try to have more useful notes for user facing sections such as "New features". |
Member
|
See #7935. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR replaces all occurrences of
numpy.fixwithnumpy.trunc. This is in response to a currently discussed deprecation ofnumpy.fixas well as performance considerations (nice, but secondary).This change should not change anything in a meaningful way, internally or externally. As such, I’m not sure whether this needs to be captured in a release note.
Cheers