Support more definitions of the Laplacian operator#7888
Support more definitions of the Laplacian operator#7888lagru wants to merge 3 commits intoscikit-image:mainfrom
Conversation
| _, laplace_op = laplacian( | ||
| image.ndim, shape=(ksize,) * image.ndim, connectivity=connectivity, sign=sign | ||
| ) | ||
| result = convolve(image, laplace_op) |
There was a problem hiding this comment.
I just noticed that the shape=... argument seems to have no effect on the current implementation on main.
scikit-image/src/skimage/restoration/uft.py
Lines 442 to 451 in bd6cfaa
only uses shape to compute the transfer function, which isn't used here... So the function making that available is confusing?
There was a problem hiding this comment.
@glemaitre, do you remember more about this from 41875cf? I currently think this was probably a misunderstanding.
So I think we can safely deprecate this argument?
| of `connectivity` from the center are considered neighbors. | ||
| `connectivity` may range from 1 (no diagonal neighbors) to `ndim` (all | ||
| neighbors are included). | ||
| sign : {-1, 1}, optional |
There was a problem hiding this comment.
We need to provide some more information here on why one might want one or the other.
There was a problem hiding this comment.
I hope we're setting the default correctly; default is not indicated here in the docstring. IIRC we wanted to flip it from our current definition?
Description
Closes #7357, closes #7724, supersedes #7366.
Checklist
./doc/examplesfor new featuresRelease note
For maintainers and optionally contributors, please refer to the instructions on how to document this PR for the release notes.