Refactor to skimage.morphology.footprint_octagon#7626
Draft
lagru wants to merge 1 commit intoscikit-image:mainfrom
Draft
Refactor to skimage.morphology.footprint_octagon#7626lagru wants to merge 1 commit intoscikit-image:mainfrom
skimage.morphology.footprint_octagon#7626lagru wants to merge 1 commit intoscikit-image:mainfrom
Conversation
The problem here is that the old API of `octagon` doesn't map very well to an API using `shape` that allows for variing dimension lengths. If no decomposition is used, I've almost figured it out...
stefanv
reviewed
Dec 10, 2024
| same length. Otherwise, an octagon is formed by cutting of the edges | ||
| of a rectangle. `cutout_length` will define the side length of these | ||
| cutouts. | ||
|
|
4 tasks
4 tasks
|
Hello scikit-image core devs! There hasn't been any activity on this PR for more than 180 days. I have marked it as "dormant" to make it easy to find. To our contributors, thank you for your contribution and apologies if this contribution fell through the cracks! Hopefully this ping will help bring some fresh attention to the review. If you need help, you can always reach out on our forum If you think that this PR is no longer relevant, you may close it, or we may do it at some point (either way, it will be done manually). If you think the PR is valuable but you no longer have the bandwidth to update it, please let us know, so that someone can take it over. 🙏 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The problem here is that the old API of
octagonand its implementation doesn't map easily to an API usingshapethat allows for varying dimension lengths. If no decomposition is used, I've almost figured it out...Let's discuss it at the meeting.
Checklist
./doc/examplesfor new featuresRelease note
For maintainers and optionally contributors, please refer to the instructions on how to document this PR for the release notes.