Add CI to release nightly free-threaded wheels#7481
Add CI to release nightly free-threaded wheels#7481stefanv merged 5 commits intoscikit-image:mainfrom
Conversation
|
I'm currently investigating an error in the test suite that is occurring under the latest 3.13 beta |
3d49c78 to
67b8197
Compare
|
Wheels are being built successfully in my fork: https://github.com/andfoy/scikit-image/actions/runs/10287231013/job/28469781344 |
| [[1, 2, 3, 1, 2], [3, 3, 5, 4, 2], [3, 4, 5, 4, 2], [3, 3, 2, 1, 2]] | ||
| ) | ||
| out = np.empty_like(image) | ||
| out = image.copy() |
There was a problem hiding this comment.
This seems to be a legit issue in this function. out needs to be initialized as a copy of image, for some reason empty_like returned a previous chunk of memory which had similar values to image, thus it was passing before the memory allocator changes in CPython 3.13
There was a problem hiding this comment.
Uff, that's a good catch. Good reminder to never rely on the content of np.empty.
There was a problem hiding this comment.
Looks good. Thanks @andfoy! 😊
What do you think about merging build_linux_39_and_above_wheels and build_linux_free_threaded_wheels? Would that be possible to make the extra CIBW_FREE_THREADED_SUPPORT and the like conditional on cp313t-* in the matrix? Maybe at a later point when we can remove the nightly installation?
|
@lagru, thanks for the review, changes should be now up in 1d7c879, which is working in my fork: https://github.com/andfoy/scikit-image/actions/runs/10354531538/job/28660020992 |
|
Thank you @andfoy |
| echo "CIBW_FREE_THREADED_SUPPORT=1" >> "$GITHUB_ENV" | ||
| echo "CIBW_BEFORE_BUILD=$NIGHTLY_INSTALL" >> "$GITHUB_ENV" | ||
| echo "CIBW_BEFORE_TEST=$NIGHTLY_INSTALL" >> "$GITHUB_ENV" | ||
| echo "CIBW_TEST_COMMAND=$TEST_COMMAND" >> "$GITHUB_ENV" |
There was a problem hiding this comment.
Wouldn't have known how to do this! Thanks for figuring it out @andfoy. 😊
Description
See #7464
This PR serves as a followup to #7463, adding a separate workflow to produce, test and upload nightly wheels to the Scientific Python Anaconda channel.
Checklist
./doc/examplesfor new featuresRelease note
For maintainers and optionally contributors, please refer to the instructions on how to document this PR for the release notes.