Fix warningfilter for deprecation in SciPy 1.12.0rc1#7275
Fix warningfilter for deprecation in SciPy 1.12.0rc1#7275mkcor merged 1 commit intoscikit-image:mainfrom
Conversation
Not sure if the filters regex was wrong previously or if SciPy changed the message of the warning slightly. In any case, it began tripping up our test workflow using the `--pre` flag and SciPy 1.12.0rc1 [1]. [1] https://github.com/scikit-image/scikit-image/actions/runs/7299807113/job/19893319329
mkcor
left a comment
There was a problem hiding this comment.
Ok, I'm not super clear on this, but this change can't hurt! Noticing, for example, under "Build package"
SciPy 1.12.0rc1
vs
scipy 1.11.4
|
I'm not following. I'm guessing that you are wondering why our CI is using SciPy 1.11.4, when this PR is talking about 1.12.0rc1? That would be because only the "linux-cp3.12-pre" workflow is using 1.12.0rc1. |
|
No, no, sorry, I'm just noticing that there might be, indeed, some regex-related issues, when I read 'SciPy' (with uppercase 'S' and 'P') vs 'scipy' -- but maybe this change is unrelated to that fix!
Yes, I saw this. But I haven't seen the PRs failing for "linux-cp3.12-pre" -- where are they? Thanks! |
|
Oh, thanks! (for reminding me I should review #7256 too 🙃) |
Description
@scikit-image/core, we may want to get this small fix in so that we can fix PRs that are failing for SciPy 1.12.0rc1.
Not sure if the filters regex was wrong previously or if SciPy changed the message of the warning slightly. In any case, it began tripping up our test workflow using the
--preflag and SciPy 1.12.0rc1. E.g. see https://github.com/scikit-image/scikit-image/actions/runs/7299807113/job/19893319329Checklist
./doc/examplesfor new featuresRelease note
Summarize the introduced changes in the code block below in one or a few sentences. The
summary will be included in the next release notes automatically: