Skip to content

Remove parallelism in face detection gallery example#7141

Merged
mkcor merged 1 commit intoscikit-image:mainfrom
lagru:hotfix-haar-example
Sep 21, 2023
Merged

Remove parallelism in face detection gallery example#7141
mkcor merged 1 commit intoscikit-image:mainfrom
lagru:hotfix-haar-example

Conversation

@lagru
Copy link
Copy Markdown
Member

@lagru lagru commented Sep 20, 2023

Description

This is meant to be a temporary hotfix while #7140 is being investigated. It naturally has a similar performance compared to the single-threaded dask solution.

cc @mkcor

Checklist

Release note

Summarize the introduced changes in the code block below in one or a few sentences. The
summary will be included in the next release notes automatically:

Remove single-threaded dask usage in face detection gallery example which fixes issues
with running the example on Windows and CI. 

This is meant to be a temporary hotfix while [1] is being investigated.
It naturally has a similar performance compared to the single-threaded
dask solution.

[1] scikit-image#7140
@lagru lagru added the 📄 type: Documentation Updates, fixes and additions to documentation label Sep 20, 2023
Copy link
Copy Markdown
Member

@mkcor mkcor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this, @lagru! It will make contributing and reviewing more comfortable meanwhile. Can you please update the 'release note' section of the PR description?

@lagru
Copy link
Copy Markdown
Member Author

lagru commented Sep 20, 2023

Done. I am on the fence whether this is actually something that should go in our maintenance category rather than documentation (in context of release notes). Feel free to edit if you see opportunity.

@mkcor
Copy link
Copy Markdown
Member

mkcor commented Sep 20, 2023

Hm, I would say Maintenance... in light of your #7142 (comment) 😉

@mkcor mkcor added 🔧 type: Maintenance Refactoring and maintenance of internals and removed 📄 type: Documentation Updates, fixes and additions to documentation labels Sep 20, 2023
@mkcor
Copy link
Copy Markdown
Member

mkcor commented Sep 20, 2023

I'll wait for one or two days before merging (following #7020).

@mkcor mkcor merged commit b8c7f85 into scikit-image:main Sep 21, 2023
@stefanv stefanv added this to the 0.22 milestone Sep 21, 2023
@lagru lagru deleted the hotfix-haar-example branch September 21, 2023 13:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🔧 type: Maintenance Refactoring and maintenance of internals

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants