Skip to content

Refactor lazy loading to use stubs & lazy_loader package#6577

Merged
jarrodmillman merged 3 commits intoscikit-image:mainfrom
stefanv:lazy-stubs
Oct 14, 2022
Merged

Refactor lazy loading to use stubs & lazy_loader package#6577
jarrodmillman merged 3 commits intoscikit-image:mainfrom
stefanv:lazy-stubs

Conversation

@stefanv
Copy link
Copy Markdown
Member

@stefanv stefanv commented Oct 12, 2022

No description provided.

@stefanv stefanv changed the title Refactor lazy loading Refactor lazy loading to use stubs Oct 12, 2022
@stefanv stefanv changed the title Refactor lazy loading to use stubs Refactor lazy loading to use stubs & lazy_loader package Oct 12, 2022
@stefanv stefanv marked this pull request as draft October 12, 2022 19:40
- Use lazy_loader package
- Use stubs to specify lazy imports
Copy link
Copy Markdown
Contributor

@jarrodmillman jarrodmillman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@stefanv
Copy link
Copy Markdown
Member Author

stefanv commented Oct 12, 2022

Once this is in, we can also do the other submodules. With the __init__.pyi format, it's much easier to transition than before.

@stefanv stefanv marked this pull request as ready for review October 13, 2022 03:55
@jarrodmillman jarrodmillman added this to the 0.20 milestone Oct 13, 2022
@jarrodmillman jarrodmillman requested a review from lagru October 13, 2022 23:49
lagru added 2 commits October 14, 2022 13:25
Format the PYI files consistently with filters/__init__.pyi by applying
black -S and isort --profile black.
Copy link
Copy Markdown
Member

@lagru lagru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I've removed an unused import in 8b379e8, and applied a consistent formatting to all PYI files in df0e54d.

Feel free to merge if you agree and once the CI is green. 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🔧 type: Maintenance Refactoring and maintenance of internals

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants