Remove preserve_range kwarg (always preserve range by default)#6319
Draft
grlee77 wants to merge 19 commits intoscikit-image:mainfrom
Draft
Remove preserve_range kwarg (always preserve range by default)#6319grlee77 wants to merge 19 commits intoscikit-image:mainfrom
grlee77 wants to merge 19 commits intoscikit-image:mainfrom
Conversation
update docs and gallery to use rescale_to_*
now there is no rescaling of the data range for any of these functions remove preserve_range option from non_local_means (always preserve range)
remove rescale_as_float internal to difference_of_guassians update use of gaussian in gallery examples fix use of gaussian in binary_blobs fix use of gaussian in skimage.feature fix use of gaussian in active_contour_model
remove rescale_as_float from all edge filters
…o this internally
…cale_input utilities keep default of normalization in a number of places where output is dependent on scale specifically: corner_fast, structure_tensor, ORB, CENSURE
required applying normalization within the visualization code
this function is insensitive to absolute scale
|
Hey, there hasn't been any activity on this pull request for more than 180 days. For now, we have marked it as "dormant" until there is some new activity. You are welcome to reach out to people by mentioning them here or on our forum if you need more feedback! Otherwise, we would be thankful for a short update, for example if you would like to continue or if you are okay with someone else doing so. In any case, thank you for your contributions so far! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
NOTE: the first commit here is #6318, so this will be easier to review after that one is merged
A subset of functions have a
preserve_rangekeyword argument that controls whether or not images with integer dtypes get rescaled to a normalized range ([0, 1] for unsigned, [-1, 1] for signed). We have discussed removing this keyword forskimage2and defaulting to not rescaling inputs except where necessary (see #5281 (comment), #5439). Another older discussion about defaulting to preserve_range=True: #1616 (comment)In addition this PR removes internal rescaling via
rescale_to_floatin many places where it currently exists. This includes all ofskimage.filters,skimage.restorationandskimage.transforms. However, there are a number of remaining cases still to address in follow-up PRs (primarily some of the cases inskimage.feature,skimage.color,skimage.exposureandskimage.segmentationas discussed in #3373 (comment)).Checklist
./doc/examples(new features only)./benchmarks, if your changes aren't covered by anexisting benchmark
For reviewers
later.
__init__.py.doc/release/release_dev.rst.example, to backport to v0.19.x after merging, add the following in a PR
comment:
@meeseeksdev backport to v0.19.xrun-benchmarklabel. To rerun, the labelcan be removed and then added again. The benchmark output can be checked in
the "Actions" tab.