Skip to content

Conversation

@grlee77
Copy link
Contributor

@grlee77 grlee77 commented Jun 11, 2021

Description

The first commit here cleans up a few residual uses of multichannel in docstring examples, parameter descriptions and warning texts.

The second commit is to update the benchmark scripts with a _channel_kwarg helper that will specify multichannel when benchmarking against skimage<0.19, but channel_axis on newer versions.

Checklist

For reviewers

  • Check that the PR title is short, concise, and will make sense 1 year
    later.
  • Check that new functions are imported in corresponding __init__.py.
  • Check that new features, API changes, and deprecations are mentioned in
    doc/release/release_dev.rst.

grlee77 added 2 commits June 11, 2021 07:36
This commit will allow benchmarks to run across versions pre/post multichannel->channel_axis transition
@grlee77 grlee77 added the 🔧 type: Maintenance Refactoring and maintenance of internals label Jun 11, 2021
@grlee77 grlee77 added this to the 0.19 milestone Jun 11, 2021
Copy link
Member

@mkcor mkcor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yay! Thank you, @grlee77 🙏

Co-authored-by: Marianne Corvellec <marianne.corvellec@ens-lyon.org>
@rfezzani rfezzani merged commit dad624b into scikit-image:main Jun 21, 2021
@rfezzani
Copy link
Member

🎉 Thank you @grlee77 for your hard work and @mkcor for the reminder 😉

@grlee77 grlee77 deleted the avoid-deprecated-multichannel branch July 8, 2021 20:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🔧 type: Maintenance Refactoring and maintenance of internals

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants